Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack name validation check #15245

Merged
merged 1 commit into from Jan 27, 2024
Merged

Fix stack name validation check #15245

merged 1 commit into from Jan 27, 2024

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Jan 24, 2024

The disable validation check for this was wrong (it did the assert if validation was disabled).

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Jan 24, 2024

Changelog

[uncommitted] (2024-01-27)

Bug Fixes

  • [engine] Fix stack name validation when PULUMI_DISABLE_VALIDATION isn't set.
    #15245

@Frassle Frassle marked this pull request as ready for review January 24, 2024 23:31
@Frassle Frassle added this pull request to the merge queue Jan 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 25, 2024
@Frassle Frassle force-pushed the fraser/emptyStackName branch 3 times, most recently from 38c5de6 to 84e5492 Compare January 26, 2024 08:51
@Frassle Frassle added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@Frassle Frassle added this pull request to the merge queue Jan 26, 2024
@justinvp justinvp removed this pull request from the merge queue due to a manual request Jan 26, 2024
@Frassle Frassle added this pull request to the merge queue Jan 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 27, 2024
@Frassle Frassle added this pull request to the merge queue Jan 27, 2024
Merged via the queue into master with commit dd5fef7 Jan 27, 2024
47 checks passed
@Frassle Frassle deleted the fraser/emptyStackName branch January 27, 2024 11:27
@justinvp justinvp mentioned this pull request Jan 31, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jan 31, 2024
### Features

- [backend] Allows the PULUMI_SKIP_CHECKPOINTS environment variable to
be set without requiring the PULUMI_EXPERIMENTAL flag.
  [#15318](#15318)

- [auto/go] Add new API to install the Pulumi CLI from the Automation
API
  [#15049](#15049)

- [auto/nodejs] Allow disabling version validation when using a custom
PulumiCommand instance
  [#15242](#15242)

- [auto/python] Add new API to install the Pulumi CLI
  [#15204](#15204)

- [auto/python] Inline programs can now be defined as async functions.
  [#15278](#15278)

- [pkg/testing] Add RequireEmptyPreviewAfterRefresh option to
ProgramTest


### Bug Fixes

- [engine] Fix a hang in preview --import-file.
  [#15203](#15203)

- [engine] Engine will now error if aliases request a parent with no
URN.
  [#15232](#15232)

- [engine] Fix stack name validation when PULUMI_DISABLE_VALIDATION
isn't set.
  [#15245](#15245)

- [engine] Fix a performance issue doing unneeded secret encryption.
  [#15306](#15306)

- [sdk/go] Include error message in local workspace validation.
  [#15279](#15279)

- [sdkgen/go] Remove pulumix references from generated enums
  [#15280](#15280)

- [programgen/nodejs] Fixes generated expression for filebase64 function
to use fs.readFileSync directly with base64 encoding option
  [#15253](#15253)

- [sdkgen/python] Use importlib.metadata instead of pkg_resources
  [#15266](#15266)


### Miscellaneous

- [auto/go] Remove obsolete note from FullyQualifiedStackName comment.
  [#15281](#15281)

- [backend/filestate] Upgrade gocloud.dev to the latest version
  [#15202](#15202)

- [sdk/python] Remove compatability code for Python 3.7 and below.
  [#15276](#15276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants