local workspace project validation should include error message #15279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Changelog[uncommitted] (2024-01-27)Bug Fixes
|
Frassle
reviewed
Jan 27, 2024
changelog/pending/20240127--sdk-go--include-error-message-in-local-workspace-validation.yaml
Outdated
Show resolved
Hide resolved
…ocal-workspace-validation.yaml Co-authored-by: Fraser Waters <frassle@gmail.com>
Co-authored-by: Fraser Waters <frassle@gmail.com>
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
1 similar comment
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
|
Thanks for the feedback! Updated. |
Frassle
approved these changes
Jan 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merge failed due to pytest errors. Not an issue with this PR itself, we'll get that fixed then get this merged. |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
### Features - [backend] Allows the PULUMI_SKIP_CHECKPOINTS environment variable to be set without requiring the PULUMI_EXPERIMENTAL flag. [#15318](#15318) - [auto/go] Add new API to install the Pulumi CLI from the Automation API [#15049](#15049) - [auto/nodejs] Allow disabling version validation when using a custom PulumiCommand instance [#15242](#15242) - [auto/python] Add new API to install the Pulumi CLI [#15204](#15204) - [auto/python] Inline programs can now be defined as async functions. [#15278](#15278) - [pkg/testing] Add RequireEmptyPreviewAfterRefresh option to ProgramTest ### Bug Fixes - [engine] Fix a hang in preview --import-file. [#15203](#15203) - [engine] Engine will now error if aliases request a parent with no URN. [#15232](#15232) - [engine] Fix stack name validation when PULUMI_DISABLE_VALIDATION isn't set. [#15245](#15245) - [engine] Fix a performance issue doing unneeded secret encryption. [#15306](#15306) - [sdk/go] Include error message in local workspace validation. [#15279](#15279) - [sdkgen/go] Remove pulumix references from generated enums [#15280](#15280) - [programgen/nodejs] Fixes generated expression for filebase64 function to use fs.readFileSync directly with base64 encoding option [#15253](#15253) - [sdkgen/python] Use importlib.metadata instead of pkg_resources [#15266](#15266) ### Miscellaneous - [auto/go] Remove obsolete note from FullyQualifiedStackName comment. [#15281](#15281) - [backend/filestate] Upgrade gocloud.dev to the latest version [#15202](#15202) - [sdk/python] Remove compatability code for Python 3.7 and below. [#15276](#15276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If project settings are not valid
contract.Requiref(proj.Validate() == nil, "proj", "Validate()")just returnsValidate()which makes it difficult to debug why the call toproj.Validate()failed. This change captures the error returned byproj.Validate()and includes that as part of the message.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change