Populate pulumi:template tag also for interactively selected templates #16308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-06-03)Bug Fixes
|
mikhailshilkov
commented
Jun 3, 2024
| @@ -201,7 +204,7 @@ func runNew(ctx context.Context, args newArgs) error { | |||
| } else if len(templates) == 1 { | |||
| template = templates[0] | |||
| } else { | |||
| if template, err = chooseTemplate(templates, opts); err != nil { | |||
| if template, err = args.chooseTemplate(templates, opts); err != nil { | |||
There was a problem hiding this comment.
This is a slightly terrifying change in terms of a potential nil reference panic. I think I checked and it should be fine - but may I ask the reviewer to double-check that we'll never pass nil here from the CLI binary (not tests)?
There was a problem hiding this comment.
Yeah, I can't find any instances other than newNewCmd.
julienp
approved these changes
Jun 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This was referenced Jun 5, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Planning to include #16322. Other than that, tentative changelog: ### Features - [auto/{go,nodejs,python}] Add support for `--all` parameter of the `stack ls` command to the Automation API [#16266](#16266) ### Bug Fixes - [cli/new] Populate pulumi:template tag also for interactively selected templates [#16308](#16308) - [backend/service] Improve error reporting when policy pack download fails [#16306](#16306) ### Miscellaneous - [sdk/python] Move dependency installation and python command invocation to Toolchain interface [#16243](#16243)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
To be merged after #16322 and #16323 Tentative changelog: ### Features - [auto/{go,nodejs,python}] Add support for `--all` parameter of the `stack ls` command to the Automation API [#16266](#16266) ### Bug Fixes - [cli/new] Populate pulumi:template tag also for interactively selected templates [#16308](#16308) - [backend/service] Improve error reporting when policy pack download fails [#16306](#16306) ### Miscellaneous - [sdk/python] Move dependency installation and python command invocation to Toolchain interface [#16243](#16243)
This was referenced Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following lines are added to
Pulumi.yamlafter apulumi newcommand:where
pulumi:templatepoints to a name or a URL of the template that was used for project instantiation.The problem is that this currently works only if the template name is specified as a CLI argument, not selected interactively. This PR fixes the field population for the interactive case by using
template.Namefor the tag value, not just the input argument.Fixes #16037
Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change