Don't unwrap functions
#2061
Merged
Don't unwrap functions
#2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/nodejs/tests/unwrap.spec.ts
Outdated
| var sentinel = function(_: () => void) {} | ||
|
|
||
| // `v` should be type `() => void` rather than `UnwrappedObject<void>`. | ||
| var _ = output(function() {}).apply(v => sentinel(v)); |
There was a problem hiding this comment.
don't really need the _ but i also don't care :)
CyrusNajmabadi
approved these changes
Oct 15, 2018
hausdorff
force-pushed
the
hausdorff/unwrap-fn
branch
from
cb2fa06
to
731ad3f
Compare
Also, to be clear. This is how the impl already works. It does not touch 'Function' instances. So this is just making sure that the TS typings reflect that fact. |
hausdorff
force-pushed
the
hausdorff/unwrap-fn
branch
from
731ad3f
to
7149cff
Compare
Suppose you have `pulumi.output(o).apply(foo)`, with `o` being type `O` and `foo` taking type `O` as an argument. If `O` is a type with methods, this will fail to type check. The reason is that `UnwrappedObject<T>` (as well as the other `Unwrapped*` types) will recursively wrap the types of field values whose type was `Function`. Since `UnwrappedObject<Function>` is not the same as `Function`, we fail to type check. Note that this does not result in an actual "boxed" object -- this is purely at the type level. This commit resolves this by considering `Function` a primitive type, which will cause us to not wrap the types of field values, instead leaving them as `Function`.
hausdorff
force-pushed
the
hausdorff/unwrap-fn
branch
from
7149cff
to
59dc7d3
Compare
|
@ellismg Encountered this as well in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose I have
pulumi.output(o).apply(foo), withobeing typeOand
footaking typeOas an argument. IfOis a type with methods,this will fail to type check.
The reason is that
UnwrappedObject<T>(as well as the otherUnwrapped*types) will recursively box the field values whose type isFunction. SinceUnwrappedObject<Function>is not the same asFunction, we fail to type check.This commit resolves this by considering
Functiona primitive type,which will cause us to not box these field values, instead leaving them
as
Function.