Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to explicitly disable delete-before-replace. #3118

Merged
merged 2 commits into from
Aug 20, 2019

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Aug 20, 2019

With these changes, a user may explicitly set deleteBeforeReplace to
false in order to disable DBR behavior for a particular resource. This
is the SDK + CLI escape hatch for cases where the changes in
pulumi/pulumi-terraform#465 cause undesirable
behavior.

Copy link
Contributor

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

With these changes, a user may explicitly set `deleteBeforeReplace` to
`false` in order to disable DBR behavior for a particular resource. This
is the SDK + CLI escape hatch for cases where the changes in
pulumi/pulumi-terraform#465 cause undesirable
behavior.
@pgavlin pgavlin merged commit 8745440 into master Aug 20, 2019
@pulumi-bot pulumi-bot deleted the pgavlin/rrDisableDBR branch August 20, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants