Add targeted replaces to update.
#3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Working on tests now. The only major question I have here is if we should have some shorthand for |
pgavlin
commented
Oct 29, 2019
| if pe.stepGen != nil && pe.stepGen.creates != nil { | ||
| news = pe.stepGen.creates | ||
| if pe.stepGen != nil { | ||
| news = pe.stepGen.urns |
There was a problem hiding this comment.
This fixes a bug that caused a "resource not found" error if a specified target was replaced rather than created or updated.
lukehoban
reviewed
Oct 29, 2019
Allow the user to specify a set of resources to replace via the `--replace` flag on the CLI. This can be combined with `--target` to replace a specific set of resources without changing any other resources. Fixes #2643.
This flag treats --replace urn as if it also implies --target urn.
pgavlin
force-pushed
the
pgavlin/replace
branch
from
c2f0f35
to
0cd2c54
Compare
lukehoban
approved these changes
Oct 30, 2019
| `--replace urn` argument. Multiple resources can be specified using `--replace urn1 --replace urn2`. In order to | ||
| replace exactly one resource, invoke `pulumi update --replace urn --target urn`. In order to treat all resources | ||
| mentioned by `--replace` as if they were also passed via `--target`, pass the `--target-replaces` flag. | ||
| [#3418](https://github.com/pulumi/pulumi/pull/3418) |
There was a problem hiding this comment.
This is no longer correct, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the user to specify a set of resources to replace via the
--replaceflag on the CLI. This can be combined with--targettoreplace a specific set of resources without changing any other
resources.
Fixes #2643.