Omit unknowns in resources in stack outputs during preview. #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
force-pushed
the
pgavlin/previewStackOutputResourceUnknowns
branch
from
fc4f960
to
11448e6
Compare
CyrusNajmabadi
approved these changes
Oct 30, 2019
If a stack output includes a `Resource`, we will as of a recent change always show the output diff, but this diff will potentially include unknowns, leading to spurious output like: ``` + namePrefix : output<string> ``` These changes supress these diffs by adding a special key to the POJO we generate for resources *during preview only* that indicates that the POJO represents a Pulumi resource, then stripping all adds of unknown values from diffs for objects marked with that key. Fixes #3314.
pgavlin
force-pushed
the
pgavlin/previewStackOutputResourceUnknowns
branch
from
6b3ca6a
to
df587bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a stack output includes a
Resource, we will as of a recent changealways show the output diff, but this diff will potentially include
unknowns, leading to spurious output like:
These changes supress these diffs by adding a special key to the POJO
we generate for resources during preview only that indicates that the
POJO represents a Pulumi resource, then stripping all adds of unknown
values from diffs for objects marked with that key.
Fixes #3314.