Fix bug in computing whether checkpoint write is necessary #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were seeing that ~all same steps were requiring checkpoint writes due to percieving a difference between `Dependencies` being `nil` and `[]URN{}` - which should be considered the same for this purpose.
CyrusNajmabadi
approved these changes
Feb 5, 2020
| sortDeps := func(deps []resource.URN) { | ||
| sort.Slice(deps, func(i, j int) bool { return deps[i] < deps[j] }) | ||
| } | ||
| sortDeps(old.Dependencies) | ||
| sortDeps(new.Dependencies) | ||
| return !reflect.DeepEqual(old.Dependencies, new.Dependencies) | ||
| // reflect.DeepEqual does not treat `nil` and `[]URN{}` as equal, so we must check for both | ||
| // lists being empty ourselves. |
There was a problem hiding this comment.
Indeed - and I do worry that effectively all our uses of reflect.DeepEqual are potentially prone to being "wrong" relative to our expectations due to this. We may need to do an audit of our use of this API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing that ~all same steps were requiring checkpoint writes due to percieving a difference between
Dependenciesbeingniland[]URN{}- which should be considered the same for this purpose.