Ensure python overlays work as expected #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack72
force-pushed
the
fix-pygen-overlays
branch
from
d8bc29d
to
5ff26a8
Compare
lukehoban
approved these changes
Mar 9, 2020
There was a problem hiding this comment.
I don't exactly follow why dropping the full path is "right" here in the general case - but if this works to unblock pulumi/pulumi-docker#141 then it is likely at least better than what we have currently.
Fixes: pulumi/pulumi-terraform-bridge#119 This allows us to specify an overlays block e.g. ``` Overlay: &tfbridge.OverlayInfo{ DestFiles: []string{ "pulumi_docker/docker.py", "pulumi_docker/image.py", }, }, ``` The overlays files are treated differently to normal module files as they are not generated. This structure means that we will emit the correct entries in the __init__.py file Without this structure (ie. pulumi_pkgname), the generator actually copies the file (i.e. docker.py) to the root of the Python SDK. This is because the structure of the Python SDK has a sub-folder than that of the NodeJS SDK I tested this using PR pulumi/pulumi-docker#141 and this now works as expected and we can take advantage of the new Python overlays for Docker
stack72
force-pushed
the
fix-pygen-overlays
branch
from
5ff26a8
to
b100f84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: pulumi/pulumi-terraform-bridge#119
This allows us to specify an overlays block e.g.
The overlays files are treated differently to normal module files
as they are not generated. This structure means that we will emit
the correct entries in the init.py file
Without this structure (ie. pulumi_pkgname), the generator actually
copies the file (i.e. docker.py) to the root of the Python SDK. This
is because the structure of the Python SDK has a sub-folder than that
of the NodeJS SDK
I tested this using PR pulumi/pulumi-docker#141
and this now works as expected and we can take advantage of the new
Python overlays for Docker