Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NodeJS codegen to use codegen.StringSet #4724

Merged
merged 4 commits into from
May 28, 2020
Merged

Update NodeJS codegen to use codegen.StringSet #4724

merged 4 commits into from
May 28, 2020

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented May 28, 2020 •
edited
Loading

@lblackstone
Fix NodeJS codegen to handle recursive types
3f2dfa3 
Track the input/output types that have been encountered
and don't recurse into previously seen types.
@lblackstone
Switch to using codegen.Set
d64808d
@lblackstone
Update NodeJS codegen to use codegen.StringSet
853a9c2
@lblackstone lblackstone added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 28, 2020
@lblackstone lblackstone requested a review from pgavlin May 28, 2020 21:36
@lblackstone
Copy link
Member Author

@pgavlin Only the last commit is relevant. It's based on another PR.

@github-actions
Copy link

Diff for pulumi-azuread with merge commit fb4d628

@github-actions
Copy link

Diff for pulumi-random with merge commit fb4d628

@github-actions
Copy link

Diff for pulumi-gcp with merge commit fb4d628

@github-actions
Copy link

Diff for pulumi-aws with merge commit fb4d628

@github-actions
Copy link

Diff for pulumi-azure with merge commit fb4d628

@lblackstone
Merge branch 'master' into lblackstone/nodejs-stringset
fe6e5db 
# Conflicts:
#	pkg/codegen/nodejs/gen.go
@github-actions
Copy link

Diff for pulumi-azuread with merge commit 918f0de

@github-actions
Copy link

Diff for pulumi-random with merge commit 918f0de

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 918f0de

@github-actions
Copy link

Diff for pulumi-azure with merge commit 918f0de

@github-actions
Copy link

Diff for pulumi-aws with merge commit 918f0de

@lblackstone lblackstone merged commit a848652 into master May 28, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/nodejs-stringset branch May 28, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lblackstone @pgavlin