Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[automation/dotnet] Add ability to capture stderr #6513

Merged
merged 5 commits into from
Mar 15, 2021
Merged

[automation/dotnet] Add ability to capture stderr #6513

merged 5 commits into from
Mar 15, 2021

Conversation

vipentti
Copy link
Contributor

Dotnet support for #6511 and also fixes #6483

NOTE: I did move the OnOutput and added the new OnStdErr action to the options base class UpdateOptions instead of duplicating them for each option type.

I tried to figure out a way to test that the StdErr action would be called, but I did not seem to find a way to get data written to the standard error stream. Even logging with Log.Warn or Log.Error would end up being written to the standard output stream.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@orionstudt
Copy link
Contributor

orionstudt commented Mar 12, 2021 •
edited
Loading

FYI OnOutput was not on the base options class because it is only used for Up & Preview. Looks good otherwise

Sorry, that's incorrect I was misremembering. Looks good.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

1 similar comment
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@vipentti
Copy link
Contributor Author

Renamed OnOutput -> OnStandardOutput and the new stderr is OnStandardError. I will update the dotnet automation examples next to utilize the new naming.

@komalali
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@komalali komalali self-assigned this Mar 12, 2021
@komalali
Copy link
Member

komalali commented Mar 12, 2021 •
edited
Loading

Thanks @vipentti. Can you please rebase this on master (we had to add a skip to the last test you added because it was causing some issues in CI due to concurrent "Run"s) and add an entry to CHANGELOG-PENDING in the "Breaking" section?

@vipentti vipentti force-pushed the vipentti/dotnet-onoutput-onstderr branch from 7e23923 to 2c878c1 Compare March 13, 2021 06:25
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@vipentti
Copy link
Contributor Author

Rebased and added an entry to CHANGELOG_PENDING

@komalali
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

2 similar comments
@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@vipentti vipentti mentioned this pull request Mar 15, 2021
Merged
@komalali komalali merged commit aa79630 into pulumi:master Mar 15, 2021
@vipentti vipentti deleted the vipentti/dotnet-onoutput-onstderr branch March 15, 2021 16:13
This was referenced Mar 18, 2021
Closed
Merged
Closed
This was referenced Mar 18, 2021
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@vipentti
[automation/dotnet] Add ability to capture stderr (pulumi/pulumi#6513)
1c2a07c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisinformedDNA MisinformedDNA MisinformedDNA left review comments

@komalali komalali komalali approved these changes

Assignees

@komalali komalali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Automation API] Consider adding OnOutput-callback to preview
4 participants
@vipentti @orionstudt @komalali @MisinformedDNA