Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Automation API] Consider adding OnOutput-callback to preview #6483

Closed
vipentti opened this issue Mar 9, 2021 · 1 comment · Fixed by #6513
Closed

[Automation API] Consider adding OnOutput-callback to preview #6483

vipentti opened this issue Mar 9, 2021 · 1 comment · Fixed by #6513
Labels
area/automation-api help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features resolution/fixed This issue was fixed

Comments

@vipentti
Copy link
Contributor

vipentti commented Mar 9, 2021

Currently the dotnet Automation API allows providing a callback Action<string>? OnOutput to Up-, Refresh- and DestroyOptions.
Is there a reason no such option is available for PreviewOptions?

From what I checked, this also applies to the python and nodejs automation APIs.
@vipentti vipentti added the kind/enhancement Improvements or new features label Mar 9, 2021
@leezen leezen added area/automation-api kind/enhancement Improvements or new features and removed kind/enhancement Improvements or new features labels Mar 9, 2021
@komalali komalali added the help-wanted We'd love your contributions on this issue label Mar 11, 2021
@komalali
Copy link
Member

@vipentti I believe this was an oversight, there is no reason that this option couldn't be added to PreviewOptions. In fact, python already includes it, it was just added to Go and thanks to this issue I just realized it's missing from Nodejs but will be added shortly.

@vipentti vipentti mentioned this issue Mar 12, 2021
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/automation-api help-wanted We'd love your contributions on this issue kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[automation/dotnet] Add ability to capture stderr vipentti/pulumi
4 participants
@leezen @vipentti @komalali @pulumi-bot