Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pulumi python docker image to python 3.9 #6706

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

followben
Copy link
Contributor

Latest stable image is 3.9.4.

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@slaiyer
Copy link

slaiyer commented Apr 6, 2021

Can we consider leaving out the patch version?
python:3.9-slim-buster seems like a better idea to me, given that patch versions bring in bugfixes and security updates.

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@followben
Copy link
Contributor Author

Sorry about the noise on this one @slaiyer - pebkac. Agreed generic 3.9 build is better - updated!

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@komalali komalali requested a review from stack72 April 6, 2021 15:28
@komalali
Copy link
Member

komalali commented Apr 6, 2021

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Apr 6, 2021

Please view the results of the PR Build + Acceptance Tests Run Here

@stack72
Copy link
Contributor

stack72 commented Apr 6, 2021

Hi @followben

thanks for the PR here - the file you have updated is only actually 1 of the containers we build. We would need to reflect the same change in:

  • docker/Python/Docker.alpine
  • docker/pulumi/Dockerfile

It wouldn't be correct to only have 1 of our containers on the latest Python. If you feel that is outside the scope of your PR then I can follow behind with this change

Thanks again

Paul

@stack72 stack72 added area/build CI/CD for pulumi/pulumi area/tooling kind/enhancement Improvements or new features labels Apr 6, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@followben
Copy link
Contributor Author

Thanks for the feedback @stack72 - I was being selfish as we only needed the default image updated. Agreed they should be in sync tho. As it turns out that was the source of my problem as they were already on different versions for some reason (default on 3.7.7, alpine on 3.8.3 and debian on 3.9.x).

That's fixed now - all on the latest release of 3.9.

@stack72
Copy link
Contributor

stack72 commented Apr 6, 2021

Thanks so much @followben

I'll get these merged and in our next release!!

I appreciate the PR here!

@stack72 stack72 merged commit f4b7a5a into pulumi:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build CI/CD for pulumi/pulumi area/tooling kind/enhancement Improvements or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants