Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"make lint" returns an accurate status code #7844

Merged
merged 3 commits into from
Aug 30, 2021
Merged

"make lint" returns an accurate status code #7844

merged 3 commits into from
Aug 30, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 25, 2021 •
edited

Description

This is mainly to allow make lint to be usable in git hooks.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Aug 25, 2021
@iwahbe iwahbe requested a review from emiliza August 25, 2021 22:20
@iwahbe iwahbe requested a review from justinvp August 28, 2021 04:40
emiliza
emiliza approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@emiliza emiliza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Works as expected.

@iwahbe iwahbe merged commit d749ce5 into master Aug 30, 2021
@iwahbe iwahbe deleted the iwahbe/make-lint-status-code branch August 30, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiliza emiliza emiliza approved these changes

@justinvp justinvp Awaiting requested review from justinvp

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iwahbe @emiliza