Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codegen/go] Slightly simplify enum type gen. #8341

Merged
merged 1 commit into from Nov 3, 2021
Merged

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Nov 2, 2021

  • Remove enumElementType, whose functionality duplicates work done in
    argsTypeImpl
  • Clarify the args- vs. Go-ness of the two element types

This is prep work for #7943. These changes should not produce codegen diffs.

- Remove enumElementType, whose functionality duplicates work done in
  argsTypeImpl
- Clarify the args- vs. Go-ness of the two element types

This is prep work for #7943.
@pgavlin pgavlin requested a review from a team November 2, 2021 23:32
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Diff for pulumi-azuread with merge commit b3bfbd3

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Diff for pulumi-random with merge commit b3bfbd3

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Diff for pulumi-kubernetes with merge commit b3bfbd3

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Diff for pulumi-gcp with merge commit b3bfbd3

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Diff for pulumi-aws with merge commit b3bfbd3

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Diff for pulumi-azure with merge commit b3bfbd3

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 3, 2021

Diff for pulumi-azure-native with merge commit b3bfbd3

@pgavlin pgavlin added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 3, 2021
@pgavlin pgavlin merged commit af151b6 into master Nov 3, 2021
@pulumi-bot pulumi-bot deleted the pgavlin/enumCleanup branch November 3, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants