Fix (Read,Invoke) denied default provider handling #9067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When denying default providers was added, we had no special handling for Reads and Invokes. This lead to confusing error messages. The fix (#8853) involved checking on invokes. This check didn't apply to several types of calls (Read) as well as blocking invokes with providers applied. This PR fixes the logic to only deny providers when they are default providers. It also pushes the change into `getProviderFromSource`, which ensures that this behavior is handled the same way (and correctly) for both Invokes and Reads.
|
Confirm that this fixes #9060 as well. |
AaronFriel
approved these changes
Feb 28, 2022
| cases = append(cases, TT{ | ||
| disableDefault: disableDefault, | ||
| hasExplicit: hasExplicit, | ||
| expectFail: disableDefault && !hasExplicit, |
There was a problem hiding this comment.
👍 surprisingly easy to read test matrix thanks to this conditional
pulumi-bot
deleted the
iwahbe/9055/generalize-deny-default-provider-handling
branch
AaronFriel
added a commit
that referenced
this pull request
Mar 1, 2022
This reverts commit 999da67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When denying default providers was added, we had no special handling for
Reads and Invokes. This lead to confusing error messages. The fix (#8853)
involved checking on invokes. This check didn't apply to several types
of calls (Read) as well as blocking invokes with providers applied.
This PR fixes the logic to only deny providers when they are default
providers.
It also pushes the change into
getProviderFromSource, which ensuresthat this behavior is handled the same way (and correctly) for both
Invokes and Reads.
Description
Fixes #9055
Fixes #9060
Checklist