fix: 🐛 resolve getPolicyDocumentOutput nil dereference (#1872)

[ghostsquad]

resolves #1872

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[ghostsquad]

After figuring out how to attach a debugger, I can further confirm that this is the issue.

EDIT
Notice that r is nil

the screenshot is unfortunately not highlight the line that actually matters here. Sorry about that.

[stack72]

Hi @ghostsquad

What version of Pulumi are you using? I believe we fixed this in Pulumi pulumi/pulumi#9067 in 3.25.1

Paul

[guineveresaenger]

hi @ghostsquad! Thank you for your pull request.

The SDKs in this repository are created via codegen, and so this change would be overwritten on the next patch release.

I'll close this PR for now but it looks like @stack72 is pointing you to a possible resolution?

[ghostsquad]

I'm not sure I understand @stack72. I'm using the latest release of this repository, which is 4.38.1

Don't know what this has to do with the Pulumi CLI. The error doesn't occur in the CLI.

[stack72]

Hi @ghostsquad

The engine is what controls this behaviour and the engine is a dependency of the CLI. We fixed the engine in the PR I linked you to an it was released as 3.25.1

The error may manifest itself in this code base but it's actually being returned from the engine

Paul

[ghostsquad]

For reference:

at 17:19:33 ❯ pulumi version
v3.26.1

But I still don't understand what voodoo you are referring to. The code that is running can be traced by go, the debugger, my IDE to this package, which is imported in my main.go:

import "github.com/pulumi/pulumi-aws/sdk/v4/go/aws/iam"

go.mod

github.com/pulumi/pulumi-aws/sdk/v4 v4.38.1

Additionally, my binary is built without help from the pulumi CLI via:

runtime:
  name: go
  options:
    binary: app.sh

app.sh

if [ "${DEBUG:-}" == "1" ]; then
  go build -o debugapp -gcflags "all=-N -l" .
  dlv --listen=:2345 --headless=true --api-version=2 --accept-multiclient exec ./debugapp
else
  go build -o app .
  ./app
fi

Thank you for taking the time to explain to me what's going on.

[ghostsquad]

If you are referring to the specific error that I found in the debugger, that's not what I'm concerned about. That was by design via this in the config

pulumi:disable-default-providers:
- '*'

The problem is that this error was never surfaced. I got a nil pointer exception, and without debugging, it was not possible to retrieve the error message.

[ghostsquad]

I updated #1873 (comment) to point out that r = nil here. Which is why *r panics.