-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cloudBackendReference.String #9240
Conversation
Are there any scenarios when this can break users? Do you want to add some tests for |
I don't think so, its only going to change for people using |
Testing these parts of the system is really awkward right now, but I plan on changing this around some more as part of the backend work and should be able to add tests then. |
Could you expand on this? I guess I'm naive but why not create a |
Because that needs a whole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
cloudBackendReference.String
didn't use the same logic for infering the default owner ascloudBackend.ParseStackReference
. This was partically evident duringpulumi stack select
where if you had two stacks "user/foo" and "org/bar" thenstack ls
would print them as:If you then set the workspace default-org
stack ls
would still print them in the same way. But when passing "foo" toParseStackReference
it would pick up the implicit owner of "org" not "user" (because the default-org is set), and then you'd get a an error that the stack you selected didn't exist.String
now matchesParseStackReference
and checks if a default-org is set and elides that name, not the user name if so.Fixes #9018
Checklist