Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

determine default publisher #8

Merged
merged 3 commits into from
Apr 26, 2022
Merged

determine default publisher #8

merged 3 commits into from
Apr 26, 2022

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Apr 25, 2022

  • Only default to Pulumi as the publisher if repo is owned by Pulumi
  • Refactor pkgversion command to take repoSlug

We should throw an error if the user doesn't pass a publisher and the
repo is not owned by Pulumi
Combine owner and repo to be repoSlug
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the error to be a bit stricter on the slug parts.

Also I request an image of a dissected slug, for Reasons. 🐌

cmd/metadata/metadata.go Show resolved Hide resolved
cmd/metadata/metadata.go Show resolved Hide resolved
cmd/pkgversion/pkgversion.go Show resolved Hide resolved
Copy link
Contributor

@guineveresaenger guineveresaenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - :shipit:

@stack72 stack72 merged commit 21c895b into master Apr 26, 2022
@stack72 stack72 deleted the determine-default-publisher branch April 26, 2022 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants