Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unifi logo + seo fix #76

Merged
merged 2 commits into from
Dec 3, 2022
Merged

fix unifi logo + seo fix #76

merged 2 commits into from
Dec 3, 2022

Conversation

susanev
Copy link
Contributor

@susanev susanev commented Nov 28, 2022

hi folks, we have a unifi logo available in the pulumi-hugo repo, so if you drop this mascot url it will get picked up and used automatically in the registry.

this also includes an seo fix for the install+config docs page

after yall merge this, it requires a new release for the registry to know about it.

dirien
dirien previously approved these changes Dec 2, 2022
Copy link

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: susanev <susan.ra.evans@gmail.com>
@susanev susanev changed the title fix unifi logo fix unifi logo + seo fix Dec 3, 2022
@ringods ringods merged commit cd36c4a into pulumiverse:main Dec 3, 2022
@ringods
Copy link
Member

ringods commented Dec 5, 2022

@susanev something I overlooked myself. For TF bridged providers, we must remove the LogoURL setting in provider/resources.go. The schema.json is generated from it, which means that if we don't remove it at the source, the logoUrl will reappear whenever the provider is rebuilt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants