Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for subdomain behavior and re-add documentaton for it #289

Merged
merged 7 commits into from
Nov 22, 2021
Merged

Add tests for subdomain behavior and re-add documentaton for it #289

merged 7 commits into from
Nov 22, 2021

Conversation

cjlarose
Copy link
Member

Fixes #286

@cjlarose
Move app lookup method to AppPool
e638ebd 
Previously, HttpServer violated the tell-don't-ask principal by making
several "asks" of the AppPool for applications that were defined given
different domains, then making decisions based on what was returned.
This change moves the responsibility of deciding the mapping of domains
to apps to the AppPool.
@cjlarose
Move responsibility of waiting for the app to be ready to http
d9ee240
@cjlarose
Rename AppPool.App => lookupApp
95e5d16 
No need to export this method anymore; it's only called by methods on
AppPool
@cjlarose cjlarose force-pushed the test-subdomain-support branch 2 times, most recently from ccf0469 to c76ec35 Compare November 22, 2021 06:48
@cjlarose cjlarose force-pushed the test-subdomain-support branch 4 times, most recently from e6e4bc1 to 0505923 Compare November 22, 2021 07:43
@cjlarose cjlarose mentioned this pull request Nov 22, 2021
Closed
@nonrational nonrational self-requested a review November 22, 2021 14:54
@nonrational nonrational merged commit 362e8c6 into puma:master Nov 22, 2021
@cjlarose
Copy link
Member Author

Thanks @nonrational !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonrational nonrational nonrational approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm, test, and document subdomain support
2 participants
@cjlarose @nonrational