Switch to constants to check Expect

puma · Jul 25, 2016 · 90a9621 · 90a9621
1 parent 5ec232d
commit 90a9621
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/puma/const.rb b/lib/puma/const.rb
@@ -219,7 +219,10 @@ module Const
 
     HTTP_VERSION = "HTTP_VERSION".freeze
     HTTP_CONNECTION = "HTTP_CONNECTION".freeze
+    HTTP_EXPECT = "HTTP_EXPECT".freeze
+    CONTINUE = "100-continue".freeze
 
+    HTTP_11_100 = "HTTP/1.1 100 Continue\r\n\r\n".freeze
     HTTP_11_200 = "HTTP/1.1 200 OK\r\n".freeze
     HTTP_10_200 = "HTTP/1.0 200 OK\r\n".freeze
 

diff --git a/lib/puma/server.rb b/lib/puma/server.rb
@@ -404,8 +404,8 @@ def handle_check
     def process_client(client, buffer)
       begin
 
-        if client.env['HTTP_EXPECT'] == "100-continue"
-          client.io << "HTTP/1.1 100 Continue\r\n\r\n"
+        if client.env[HTTP_EXPECT] == CONTINUE
+          client.io << HTTP_11_100
         end
 
         clean_thread_locals = @options[:clean_thread_locals]