Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add timeout configuration by request #265

Closed
shingara opened this issue May 22, 2013 · 2 comments
Closed

[FEATURE REQUEST] Add timeout configuration by request #265

shingara opened this issue May 22, 2013 · 2 comments

Comments

@shingara
Copy link

There are no configuration of timeout in puma.

By example, I have a long request with some infinite loop, I need restart my puma to stop this loop. It can be good to have a timeout configuration to stop the request if this timeout is reach and send a 408 http code.

Unicorn and thin has this configuration. But not found on puma.

@evanphx
Copy link
Member

evanphx commented May 22, 2013

This is not a concern that I want puma to have. If you want to have timeout requests, the best way would be to write a Rack middleware that handles it the way you want. The reason I don't want it to be in puma because, imho, it's not a one-size-fits-all situation. Puma is used for long polling as well as short requests, so the problem is better solved an the Rack middleware layer.

@evanphx evanphx closed this as completed May 22, 2013
@shingara
Copy link
Author

I understand.

Thanks for the explain and the idea to do it on a rack-middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants