Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jungle): change pid existence check's condition branches #1650

Merged
merged 1 commit into from
Feb 20, 2019

Conversation

adam101
Copy link
Contributor

@adam101 adam101 commented Sep 18, 2018

Pull request #1545 broke the ability to stop and restart running instances. The old version of checking $PID existence was truthy on non-existence, now it's truthy on existence.

Example in case of existing PID 1209:

$ if [ "`ps -A -o pid= | grep -c 1209`" -eq 0 ]; then echo true; else echo false; fi;
true
$ if ps -p 1209 > /dev/null; then echo true; else echo false; fi;
false

@p8
Copy link
Contributor

p8 commented Oct 5, 2018

This fixes an issue we had with stopping and restarting. 👍

@evanphx evanphx merged commit 4ea9302 into puma:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants