jungle: Using ps -p will check correctly whether $PID exists
#1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is appropriate to use `ps -p` in that place. Under certain conditions, existing code ``[ "`ps -A -o pid= | grep -c $PID`" -eq 0 ]`` may behave incorrectly. For example, if the content of $PID happens to be a short string (such as `199`), and another process includes the string (process such as `2199`), then unfortunately `grep -c` will return positive number even if `199` is not running.
|
Paging previous contributors @vipulnsward @michaelsauter @snow @kwilczynski |
|
Thanks for paging! We never had the issue described here, but I'd agree with @hoshinotsuyoshi that this needs fixing. |
kwilczynski
approved these changes
Mar 28, 2018
|
Hi @hoshinotsuyoshi, thank you fixing this! A side note - this whole script is almost crying out loud to be re-written and maintained, somewhat. |
|
Thank you! |
hoshinotsuyoshi
deleted the
jungle_check_correctly_whether_the_pid_exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that It is appropriate to use
ps -pin that place.I think that under certain conditions, existing code
[ "`ps -A -o pid= | grep -c $PID`" -eq 0 ]may behave incorrectly.For example, if the content of $PID happens to be a short string(such as
199), and another process includes the string(process such as2199), then unfortunatelygrep -cwill returnpositive number even if
199is not running.