-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration: Get environment from RAILS_ENV, too #2022
Configuration: Get environment from RAILS_ENV, too #2022
Conversation
ac9f3d7
to
cf6412a
Compare
5ce7365
to
7f2e147
Compare
ENV.delete 'RACK_ENV' | ||
|
||
Puma::CLI.new ["--environment", @environment] | ||
|
||
assert_equal ENV['RACK_ENV'], @environment | ||
assert_equal @environment, ENV['RACK_ENV'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves the output on failing - the order of arguments is: assert_equal exp, actual
@olleolleolle friendly nudge/reminder to fix the failing tests |
Huh, it's just like I forgot to push one of the files. I'll get to my computer and investigate! |
a6545a3
to
9a7f5c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At last, I found something.]
@nateberkopec There, I think this is ready for a Squash now. |
- as well as from RACK_ENV - this is part of the effort to bring the configuration defaults from the puma-heroku plugin to Puma
d763861
to
596fe0c
Compare
This PR changes configuration defaults.
The default value for environment is also read from
RAILS_ENV
, ifRACK_ENV
can't be found.Overview
See #1949
The goal of that Issue is that configuration defaults in puma/puma-heroku move into lib/puma/configuration.rb.