-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load JSON at runtime #2269
Load JSON at runtime #2269
Conversation
Closes puma#2206
It is working with my reproduction example ;) I have mixed feelings about this PR as it fixes the issue but isn't really future proof |
In what sense? Loading/requiring at runtime is essentially the same as autoload. |
What I meant was if someone in a future commit adds a |
Given the possible issues with default gems, I think it would be worthwhile to autoload json, psych/yaml, and openssl. Using autoload removes the need for adding multiple requires when loading at runtime. I'll have a look at all three. |
I'm gonna roll with this for now, we can do a longterm fix later. |
Description
Fixes loading JSON when Gemfile contains JSON versions that differ from the default gem or previously loaded versions. Various versions of Bundler have had issues with default gems, as it also loads some of them.
This PR changes JSON loading to runtime.
Closes #2206
Your checklist for this pull request
[changelog skip]
the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.