Fixed number of arguments in Puma::Events#unknown_error

[paneq]

The method is actually called with 4 arguments : https://github.com/puma/puma/blob/master/lib/puma/server.rb#L289
Even the documentation of it mentions the env argument.

[seamusabshere]

this should fix #54

[seamusabshere]

hey @paneq, you also need to fix line 184 of server.rb:

lib/puma/server.rb:
  182                client.close rescue nil
  183              rescue Object => e
  184:               @events.unknown_error self, e, "Listen loop"
  185              end
  186            end

You could change it to

@events.unknown_error self, nil, e, "Listen loop"

[seamusabshere]

hey @evanphx it's also possible that you don't want #unknown_error to accept env... either way, here's where the problems are:

lib/puma/server.rb:
  182                client.close rescue nil
  183              rescue Object => e
  184:               @events.unknown_error self, e, "Listen loop"  # <- 3 args
  185              end
  186            end
  ...
  287        # Server error
  288        rescue StandardError => e
  289:         @events.unknown_error self, env, e, "Read"          # <- 4 args
  290  
  291        ensure
  ...
  295            # Already closed
  296          rescue StandardError => e
  297:           @events.unknown_error self, env, e, "Client"      # <- 4 args
  298          end
  299        end

[evanphx]

Yep, I'll have this fixed today and released. Thanks!

[evanphx]

Fixed by 17219d9