Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parasol Henbee input bug #317

Closed
anewuser opened this issue Jul 26, 2023 · 11 comments
Closed

Parasol Henbee input bug #317

anewuser opened this issue Jul 26, 2023 · 11 comments

Comments

@anewuser
Copy link
Contributor

Hello. Parasol Henbee (Japan) has an input bug:

  • Hold the button to start moving
  • Press before releasing

Result: The character will keep walking right instead of turning left.

I'm not sure if this is a game bug or an emulation issue. It is always reproducible on puNES, but happens less often on Mesen 2.0.0. Could you please look into it and maybe disable Left+Right for this game?

@negativeExponent
Copy link

by default, puNES should have simultaneous UP+DOWN and LEFT+RIGHT disallowed. in Settings, Input there is an option to do so if needed, but it seems the option is not working at all.

@punesemu
Copy link
Owner

Sorry for only replying now, could you try with the latest WIP?

@anewuser
Copy link
Contributor Author

anewuser commented Oct 18, 2023

Thank you for looking into it. The last commit improved Parasol Henbee a bit when Left+Right is disabled, but now most other games from Dig Dug to SMB are unplayable with a keyboard. These can't be the default settings.

@punesemu
Copy link
Owner

I thought I'd solve it quickly, but I underestimated the issue. The problem was more complicated than I expected. Could you try with the latest WIP?

@anewuser
Copy link
Contributor Author

anewuser commented Oct 18, 2023

All movements seem to be working perfectly now (including in Parasol Henbee!), but I found a related issue that affects every game:

  • Hold the button to start moving
  • Click on a puNES menu before releasing

Result: the button stays down even after you release it:

Balloon.Fight.USA.webm

@punesemu
Copy link
Owner

Thanks so much for the test but above all thanks for the initial report, you made me discover a bug that had always been present.

All movements seem to be working perfectly now (including in Parasol Henbee!), but I found a related issue that affects every game:

  • Hold the button to start moving
  • Click on a puNES menu before releasing

Result: the button stays down even after you release it:

I will take a look at this issue, I will keep you informed.

@punesemu
Copy link
Owner

I should have solved it with the commit 24451d6, please try the last WIP.

@4zbest
Copy link

4zbest commented Oct 20, 2023

Schermafdruk van 2023-10-20 02-30-04

Sorry, still broken. Build from the suggested commit but result is the same. Problem started after update of my system, which includes puNES.

@4zbest
Copy link

4zbest commented Oct 20, 2023

I downgraded to 0.109 and controller issues went away

@punesemu
Copy link
Owner

All movements seem to be working perfectly now (including in Parasol Henbee!), but I found a related issue that affects every game:

  • Hold the button to start moving
  • Click on a puNES menu before releasing

Result: the button stays down even after you release it:

So you, with the build from the last commit, have this problem but with the controller? In fact, the tests I did were performed only with keyboard input, tomorrow I will test with my gamepad. Just out of curiosity, can you do a test with the keyboard?

@anewuser
Copy link
Contributor Author

anewuser commented Oct 23, 2023

Everything is working fine for me on Windows now. The person who said it is still broken was somebody else, and since he mentioned automatic puNES updates from his Linux distribution, which I assume only happen for stable releases, I don't think he actually tried the latest build.

@4zbest Try the WIP AppImage, and then please file a new issue with more details about your system if you still experience any input bugs.

@punesemu Thank you again for taking the time to fix these issues. Parasol Henbee can be easily overlooked because people don't realize that this screen is actually a difficulty selector:

Parasol Henbee (Japan)_000001

Playing it with this translation hack reveals that it is asking the player's age, and answering "10" sets the difficulty to hard:

Parasol Henbee (Japan)  T-En by Zynk Oxhyde v1 0 _000002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants