Custom park and serialize without creating a new serializer #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corda uses
parkAndSerialize
with a custom FiberWriter that takes it serializer from a pool of pre-created serializers - hence it does not use the Kryo serializer thatparkAndSerialize()
creates for every single call.Profiling has shown that creating a Kryo serializer has a non-trivial cost in terms of CPU cycles, and as it does not get used in our case, this effort is completely wasted. Therefore, I have created a small patch that allows to parkAndSerialize with a custom writer without creating a new serializer.