Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed GetClosestMethod to find item with the nearest edge instead o… #182

Closed

Conversation

faeriedust
Copy link

…f the one with the nearest upper left corner. This fixes my use case in which the items were nested

…f the one with the nearest upper left corner. This fixes my use case in which the items were nested
@faeriedust
Copy link
Author

faeriedust commented May 17, 2016

Oh.. this won't work if the contents of the list item are larger than the outer list item... Though this situation is pretty weird lol

@faeriedust
Copy link
Author

I guess ideal approach would be to just handle nested items directly, and not allow the inner ones?

@punker76
Copy link
Owner

@faeriedust Can you create an example for this? Would be much easier to debug and find a solution. Thx

@faeriedust
Copy link
Author

faeriedust commented May 17, 2016

I gave example in #181, though not coded out.
Not sure if I'll have to time to write out separated code from my project or not, probably not

@faeriedust
Copy link
Author

Actually I will try

@faeriedust
Copy link
Author

faeriedust commented May 19, 2016

@punker76

https://github.com/faeriedust/GongWPFDemo

The master branch illustrates the bug when you try to move a job to below task F. (It won't let you.)
The GetClosestWithNestedItemsFix branch illustrates how my commit fixes it (though there are probably other ways of handling it as well.)

@punker76 punker76 added this to the v1.0.0 milestone Aug 1, 2016
@punker76
Copy link
Owner

punker76 commented Aug 1, 2016

@faeriedust Thx for the sample to reproduce the issue, it helps me to find out what's going wrong! And this issue should be fixed with f877268

@punker76 punker76 closed this Aug 1, 2016
@punker76
Copy link
Owner

punker76 commented Aug 3, 2016

@faeriedust Oh yeah, I take your PR for #188 Big THX!

@faeriedust
Copy link
Author

Glad it helped. :D

punker76 added a commit that referenced this pull request Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants