Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several changes to 3D and 2D detector #1168

Merged
merged 8 commits into from
Apr 30, 2018
Merged

Conversation

euryalus
Copy link
Contributor

@euryalus euryalus commented Apr 30, 2018

  1. Added a loss function to the sphere optimization in order to increase robustness with outliers. The loss scale (0.01) was optimized to make standard deviations of sphere positions minimal.
  2. In the 2D-detector made sure that in the end, really the best candidate is chosen and not just the last of all candidates that gets over the threshold set by final_perimeter_ratio_range_min.
  3. In the 2D-detector, approximate paths of candidate ellipses are resolved to polylines before they are compared. Also, not all raw_edges are used to determine the ellipse support, but only the edges from the respective polyline.
  4. In the 2D-detector, the final goodness of the fit is calculated on the the very final fit of the ellipse and also based on final_edges, instead of on all the raw_edges.
  5. In the 2D-detector, the goodness of an ellipse fit now is also proportional to a factor depending on the ratio between support edges and all edges used in the fit. The ratio is exponentiated with an exponent larger 1.0, in order to make it harder for an ellipse fit to have very high confidence. This is also implemented in the string prior case.
  6. Added a field to Detector2DProperties to set support_pixel_ratio_exponent, used in the calculation of the goodness of a fit. Setting this to a value larger 1.0, makes it harder for an ellipse to have a very high confidence. Setting it to zero, recovers the former way of calculating the goodness.

@euryalus euryalus changed the title CauchyLoss function in Swirski sphere optimization Small changes to 3D and 2D detector Apr 30, 2018
@euryalus euryalus changed the title Small changes to 3D and 2D detector Several changes to 3D and 2D detector Apr 30, 2018
…e is chosen. In particular, also the ellipse support is not calculated anymore from all the raw_edges, but only from the edges in the polyline.
…d on the final fit and only on the final edges of the contour.
…r that takes into account the ratio of support edges (i.e. edges close to the fit ellipse) to all edges that the fit is based on.
@mkassner mkassner merged commit 1c70890 into pupil-labs:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants