Improve fingertip calibration performance #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papr
suggested changes
Jun 28, 2018
| ---------------------------------------------------------------------------~(*) | ||
| ''' | ||
|
|
||
| from . fingertip_calibration import Fingertip_Calibration |
There was a problem hiding this comment.
Please use the fully qualified import instead of relative imports:
from calibration_routines.fingertip_calibration import Fingertip_CalibrationThere was a problem hiding this comment.
try:
import torch
from . fingertip_calibration import Fingertip_Calibration
except ImportError:
from calibration_routines.fallback_fingertip_calibration import Fingertip_Calibrationfallback_fingertip_calibration.py would implement a dummy calibration plugin that shows an info text with a warning that torch is required for the actual plugin to work.
| import torch | ||
| from .models.unet import UNet | ||
| from .models.ssd_lite import build_ssd_lite | ||
|
|
There was a problem hiding this comment.
Please use the fully qualified import instead of relative imports as I mentioned above.
Use the fully qualified import
Follow the Best of the Best Practices (BOBP) Guide for Python
papr
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt CNN methods for hand and fingertip detector to improve the accuracy and robustness of the detection.
GPUs will be utilized if they are available.