Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eye_movement detector and Windows C++ docs #1828

Merged
merged 6 commits into from Mar 24, 2020
Merged

Conversation

pfaion
Copy link
Contributor

@pfaion pfaion commented Mar 17, 2020

I noticed that the only thing we need visual studio for on Windows was nslr, which did not have prebuilt wheels. Since we deprecated the eye_movement detector, we could actually get rid of nslr.

  • removed all eye_movement code and replaced cross-module used code
  • removed nslr as dependency for all platforms
  • cleaned up Windows docs:
    • we don't need a hard-coded C:\work anymore!
    • we don't need Visual Studio
    • we don't need the developer command prompt, simple cmd.exe is enough
    • we don't need OpenCV binaries anymore in pupil_external
    • I removed the notes on Windows paths, since users don't need to adjust paths anymore
    • I also removed old docs for installing optimization_calibration and the therefore needed ceres install instructions

@pfaion pfaion requested a review from papr March 17, 2020 15:26
docs/dependencies-windows.md Outdated Show resolved Hide resolved
Co-Authored-By: Pablo Prietz <pablo@prietz.org>
@pfaion pfaion requested a review from papr March 19, 2020 16:01
@papr papr merged commit 7417f6c into develop Mar 24, 2020
@papr papr deleted the remove-eye-movement branch March 24, 2020 12:56
@pfaion pfaion restored the remove-eye-movement branch August 4, 2020 09:45
@pfaion pfaion deleted the remove-eye-movement branch August 4, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants