Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1876 #1879

Merged
merged 2 commits into from May 18, 2020
Merged

Fix #1876 #1879

merged 2 commits into from May 18, 2020

Conversation

romanroibu
Copy link
Contributor

@romanroibu romanroibu commented May 15, 2020 •
edited

Fixes #1876

@romanroibu romanroibu changed the base branch from master to develop May 15, 2020 11:29
@romanroibu
Copy link
Contributor Author

Note: I don't really know how to properly test this, since it happens in an edge case where cv2.findHomography returns None

@romanroibu romanroibu requested a review from papr May 15, 2020 11:30
@papr papr merged commit 1edbafe into develop May 18, 2020
@papr papr added plugin: surface_tracker Issues and PRs related to the Surface Tracker plugin type: bug labels May 18, 2020
@pfaion pfaion deleted the fix-#1876 branch May 18, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papr papr papr approved these changes

Assignees
No one assigned
Labels
plugin: surface_tracker Issues and PRs related to the Surface Tracker plugin type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Surface._find_homographies raises TypeError
2 participants
@romanroibu @papr