Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Capture from crashing during calibration when there is no reference data #1960

Merged
merged 5 commits into from Jul 7, 2020
Merged

Prevent Capture from crashing during calibration when there is no reference data #1960

merged 5 commits into from Jul 7, 2020

Conversation

romanroibu
Copy link
Contributor

Fixes #1924

@romanroibu romanroibu changed the base branch from master to develop July 7, 2020 09:24
@romanroibu romanroibu requested a review from papr July 7, 2020 09:24
@romanroibu romanroibu requested a review from pfaion July 7, 2020 09:56
pfaion
pfaion suggested changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@pfaion pfaion left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a calibration with no reference data, I get this log flood every frame continuously:

world - [DEBUG] gaze_mapping.gazer_3d.gazer_headset: Prediction failed because left model is not fitted
world - [DEBUG] gaze_mapping.gazer_3d.gazer_headset: Prediction failed because right model is not fitted

Can we fix this as well?

I guess the Gazer shouldn't even work if the calibration fails?

@papr
Copy link
Contributor

papr commented Jul 7, 2020

Not sure how that can be possible. The gazer sets itself to alive=False in case there is a calibration error. This PR raises NotEnoughReferenceDataError if there is no reference data. So either there was reference data, but not enough pupil-ref-matches to fit the monocular models, or the gazer stays alive. The latter would be a bug. Please try to reproduce the issue @pfaion

@papr
Copy link
Contributor

papr commented Jul 7, 2020

I am able to reproduce the log flood.

@papr
Copy link
Contributor

papr commented Jul 7, 2020

I found the issue. The gazer sets itself as g_pool.active_gaze_mapping_plugin even if calibration fails. I will create a new PR.

@pfaion
Copy link
Contributor

pfaion commented Jul 7, 2020

Ok, then we don't consider this part of this PR.

@papr papr merged commit a3139f5 into develop Jul 7, 2020
@papr papr deleted the no-ref-data-crash branch July 7, 2020 12:29
This was referenced Jul 7, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@papr papr papr approved these changes

@pfaion pfaion pfaion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capture crashes if no reference data was collected during a calibration
3 participants
@romanroibu @papr @pfaion