Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msgpack dependency #2068

Merged
merged 10 commits into from
Dec 9, 2020
Merged

Update msgpack dependency #2068

merged 10 commits into from
Dec 9, 2020

Conversation

romanroibu
Copy link
Contributor

@romanroibu romanroibu commented Dec 8, 2020

Fixes #1830 and #1419

@romanroibu romanroibu requested a review from papr December 8, 2020 08:49
pupil_src/shared_modules/file_methods.py Outdated Show resolved Hide resolved
pupil_src/shared_modules/file_methods.py Outdated Show resolved Hide resolved
pupil_src/shared_modules/raw_data_exporter.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
papr added a commit to pupil-labs/hmd-eyes that referenced this pull request Dec 8, 2020
pupil-labs/pupil#2068 introduces msgpack 1.0 compatibility which requires all msgpack dictionary keys to be strings. To keep backwards compatibility, we test for the int key first, and convert to string if it is not present.
@papr
Copy link
Contributor

papr commented Dec 9, 2020

Please make a PR to adjust https://docs.pupil-labs.com/developer/core/overview/#gaze-datum-format accordingly.

@papr papr merged commit cae2404 into develop Dec 9, 2020
@papr papr deleted the msgpack-update branch December 9, 2020 09:47
papr added a commit to pupil-labs/pupil-docs that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants