Added imu_timeline.py to shared_modules #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… plugin for recordings with no IMU data
|
@N-M-T @papr I've updated the plugin to prevent it from being loaded by default unless:
Also removed the checks that Neil mentioned above. Tested this behaviour with a Pupil Invisible recording and a Pupil Capture recording. |
romanroibu
approved these changes
Jun 22, 2021
papr
suggested changes
Jun 23, 2021
papr
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@romanroibu My original method for determining whether or not a PI recording was loaded was to identify the presence of IMU data (line 269). Then I used bool 'is_invisible_rec' to disable interaction with the Plugin (e.g. line 288) when it wasn't.
I think these checks can safely be removed if the plugin is only loaded with PI recordings. However, there have been a few cases where the IMU was missing due to hardware failure. In which case it might be worth leaving these conditions in?