Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix renaming world video file if no file was written #2186

Merged
merged 1 commit into from Sep 15, 2021

Conversation

papr
Copy link
Contributor

@papr papr commented Sep 13, 2021

Follow up PR for #2167

  • Fixes crash below
  • Demotes "No world video recorded" log message from error to warning

Crash if no world camera is connected during recording:

world - [ERROR] launchables.world: Process Capture crashed with trace
Traceback (most recent call last):
  File ".../pupil/pupil_src/launchables/world.py", line 741, in world
    p.on_notify(n)
  File ".../pupil/pupil_src/shared_modules/recorder.py", line 289, in on_notify
    self.stop()
  File ".../pupil/pupil_src/shared_modules/recorder.py", line 497, in stop
    self.writer.release()
  File ".../pupil/pupil_src/shared_modules/av_writer.py", line 243, in release
    self.close()
  File ".../pupil/pupil_src/shared_modules/av_writer.py", line 234, in close
    os.rename(self.output_file_path_in_porgress, output_file_path)
FileNotFoundError: [Errno 2] No such file or directory: '.../recordings/2021_09_08/000/world.mp4.writing' -> '.../recordings/2021_09_08/000/world.mp4'

@papr papr requested a review from N-M-T September 13, 2021 19:47
@papr papr merged commit 3269ec3 into develop Sep 15, 2021
@papr papr deleted the fix_video_renaming branch September 15, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant