Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix confidence graphs in Pupil Player for pre-2.0 recordings #2191

Merged
merged 1 commit into from Sep 23, 2021
Merged

Fix confidence graphs in Pupil Player for pre-2.0 recordings #2191

merged 1 commit into from Sep 23, 2021

Conversation

papr
Copy link
Contributor

@papr papr commented Sep 21, 2021

Previously, the confidence graphs in Pupil Player had no data for pre-2.0 recordings. This PR fixes this by falling back to the legacy pupil topic.

https://app.clickup.com/t/nz7r5x

@papr papr requested a review from N-M-T September 21, 2021 17:21
N-M-T
N-M-T approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@N-M-T N-M-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The confidence graphs are displayed as expected.

@papr papr merged commit ad9e177 into develop Sep 23, 2021
@papr papr deleted the conf_graphs_pre-2.0_recs branch September 23, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-M-T N-M-T N-M-T approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@papr @N-M-T