Validate the footer links text #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-learner
changed the title
bodhish
requested changes
Aug 31, 2023
app/frontend/schools/settings/components/SchoolCustomize__LinkComponent.res
Outdated
Show resolved
Hide resolved
app/frontend/schools/settings/components/SchoolCustomize__LinkComponent.res
Outdated
Show resolved
Hide resolved
app/frontend/schools/settings/components/SchoolCustomize__LinkComponent.res
Show resolved
Hide resolved
bodhish
requested changes
Sep 4, 2023
app/frontend/schools/settings/components/SchoolCustomize__LinkComponent.res
Outdated
Show resolved
Hide resolved
app/frontend/schools/settings/components/SchoolCustomize__LinksEditor.res
Outdated
Show resolved
Hide resolved
bodhish
previously approved these changes
Sep 7, 2023
Co-authored-by: Bodhish Thomas <bodhish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #1399
Mutatorsen.yml@pupilfirst/developers
Merge Checklist
- [] Check if route, query, or mutation authorization looks correct.- Add tests for authorization, if required.- [ ] Update developer and product docs, where applicable.- [ ] Check if new tables or columns that have been added need to be handled in the following services:-Users::DeleteAccountService-Courses::CloneService-Courses::DeleteService-Courses::DemoContentService-Levels::CloneService-Schools::DeleteService- [ ] Check if changes in packaged components have been published tonpm.- [ ] Add development seeds for new tables.- [ ] If the updates involve Graph mutations ensure that the files are migrated to the new approach without a mutator.