Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken cmake regex #443

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fixes broken cmake regex #443

merged 2 commits into from
Apr 26, 2024

Conversation

mrjimenez
Copy link
Collaborator

@mrjimenez mrjimenez commented Apr 25, 2024

That is the output

-- Found Git: /usr/bin/git (found version "2.44.0") 
-- Extracted package name is libupnp
-- Setting package-version to 1.14.20
-- Left from parsing: ,mroberto@users.sourceforge.net
-- Setting ixml-soversion to 11.1.2
-- Setting upnp-soversion to 17.1.11
-- package-version is 1.14.20
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
...

@loqs
Copy link

loqs commented Apr 25, 2024

Being pedantic [0-9]* matches zero or more times. Is it valid for any part of the triplet to be empty? Or should it be [0-9]+ to match one or more times?

@mrjimenez
Copy link
Collaborator Author

Hi @dvzrv do you think you can test it? If this is ok for you I will do another release to include this.

@mrjimenez
Copy link
Collaborator Author

Being pedantic [0-9]* matches zero or more times. Is it valid for any part of the triplet to be empty? Or should it be [0-9]+ to match one or more times?

Totally correct, lets fix it.

@mrjimenez mrjimenez merged commit 61b7944 into branch-1.14.x Apr 26, 2024
43 checks passed
@mrjimenez mrjimenez deleted the fix_broken_cmake branch April 26, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants