fix: setRequestInterception and setExtraHTTPHeaders not working toget…

…her (#1734) This patch starts lowering header keys while generating request hashes. Fixes #1729.
puppeteer · Jan 10, 2018 · 5843f6f · 5843f6f
1 parent dcc1b24
commit 5843f6f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/lib/NetworkManager.js b/lib/NetworkManager.js
@@ -571,10 +571,12 @@ function generateRequestHash(request) {
   if (!normalizedURL.startsWith('data:')) {
     const headers = Object.keys(request.headers);
     headers.sort();
-    for (const header of headers) {
-      if (header === 'Accept' || header === 'Referer' || header === 'X-DevTools-Emulate-Network-Conditions-Client-Id')
+    for (let header of headers) {
+      const headerValue = request.headers[header];
+      header = header.toLowerCase();
+      if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id')
         continue;
-      hash.headers[header] = request.headers[header];
+      hash.headers[header] = headerValue;
     }
   }
   return JSON.stringify(hash);

diff --git a/test/test.js b/test/test.js
@@ -1332,6 +1332,16 @@ describe('Page', function() {
       const response = await page.goto(server.EMPTY_PAGE);
       expect(response.ok()).toBe(true);
     });
+    it('should works with customizing referer headers', async({page, server}) => {
+      await page.setExtraHTTPHeaders({ 'referer': server.EMPTY_PAGE });
+      await page.setRequestInterception(true);
+      page.on('request', request => {
+        expect(request.headers()['referer']).toBe(server.EMPTY_PAGE);
+        request.continue();
+      });
+      const response = await page.goto(server.EMPTY_PAGE);
+      expect(response.ok()).toBe(true);
+    });
     it('should be abortable', async({page, server}) => {
       await page.setRequestInterception(true);
       page.on('request', request => {