fix: setRequestInterception and setExtraHTTPHeaders not working together (#1729) #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslushnikov
reviewed
Jan 9, 2018
lib/NetworkManager.js
Outdated
| @@ -569,12 +569,16 @@ function generateRequestHash(request) { | |||
| }; | |||
|
|
|||
| if (!normalizedURL.startsWith('data:')) { | |||
| const headers = Object.keys(request.headers); | |||
| headers.sort(); | |||
| for (const header of headers) { | |||
There was a problem hiding this comment.
can we please minimize the change? I believe you can add a header.toLowerCase() as the first line in the loop:
for (let header of headers) {
header = header.toLowerCase();
if (key === 'accept' || key === 'referer' ...)
}| @@ -1321,6 +1321,16 @@ describe('Page', function() { | |||
| const response = await page.goto(server.EMPTY_PAGE); | |||
| expect(response.ok()).toBe(true); | |||
| }); | |||
| it('should works with customizing referer headers', async({page, server}) => { | |||
| await page.setExtraHTTPHeaders({ 'referer': server.EMPTY_PAGE }); | |||
There was a problem hiding this comment.
this is a good test, thank you.
aslushnikov
approved these changes
Jan 10, 2018
There was a problem hiding this comment.
@yujiosaka I've slightly changed your code; I hope you don't mind. Thank you for fixing this!
|
@aslushnikov thanks! |
igorshapiro
pushed a commit
to WiserSolutions/puppeteer
that referenced
this pull request
Jan 16, 2018
…her (puppeteer#1734) This patch starts lowering header keys while generating request hashes. Fixes puppeteer#1729.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a fix to the problem that
page.gotoresolves tonull.Setting referer does not work properly, but that should be discussed here.
Fixes: #1729