docs: fix typo in Viewport fields (#9293)

The `deviceScalarFactor` field of `Viewport` is actually named `deviceScaleFactor`.
puppeteer · Nov 23, 2022 · 7c7e381 · 7c7e381
1 parent b6ffa73
commit 7c7e381
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/docs/api/puppeteer.page.viewport.md b/docs/api/puppeteer.page.viewport.md
@@ -20,7 +20,7 @@ class Page {
 
 - `height`: page's height in pixels
 
-- `deviceScalarFactor`: Specify device scale factor (can be though of as dpr). Defaults to `1`.
+- `deviceScaleFactor`: Specify device scale factor (can be though of as dpr). Defaults to `1`.
 
 - `isMobile`: Whether the meta viewport tag is taken into account. Defaults to `false`.
 

diff --git a/docs/contributing.md b/docs/contributing.md
@@ -322,3 +322,21 @@ In the event release-please fails, the following needs to be done:
 
 2. Create a GitHub release for each package, following the practice of previous
    releases.
+
+## Bug and PR triage
+
+[Check incoming bug reports](https://github.com/puppeteer/puppeteer/issues) that do not have a `confirmed` or `needs-feedback` label:
+
+1. Make sure the issue labeled as either `bug` or `feature`.
+2. If the issue does not have a clear repro or you cannot repro, ask for the repro and set the `needs-feedback` label.
+3. Follow-up on the issues you previously asked for a feedback on (you should get a notification on GitHub when the user responds).
+4. If the user does not provide feedback, the issue will be closed by the stale bot eventually.
+5. If you are able to reproduce the issue, add the label "confirmed".
+6. If the bug is on the Chromium side, create a corresponding crbug.com issue and label the Github issue with the "upstream" label and post a link to crbug.com in the comments.
+7. If the issue is not related to either Puppeteer or Chromium, close the issue.
+8. If the issue is about missing/incorrect documentation, label it as `documentation`.
+
+Issues with PDFs:
+
+1. If the issue reproduces using the regular print dialog and/or headful, file a crbug.com against the Blink Layout component.
+2. If the issue is specific to the headless headless, file an issue on crbug.com against the headless component.
diff --git a/packages/puppeteer-core/src/api/Page.ts b/packages/puppeteer-core/src/api/Page.ts
@@ -1948,7 +1948,7 @@ export class Page extends EventEmitter {
    *
    * - `height`: page's height in pixels
    *
-   * - `deviceScalarFactor`: Specify device scale factor (can be though of as
+   * - `deviceScaleFactor`: Specify device scale factor (can be though of as
    *   dpr). Defaults to `1`.
    *
    * - `isMobile`: Whether the meta viewport tag is taken into account. Defaults

diff --git a/packages/puppeteer-core/src/common/Page.ts b/packages/puppeteer-core/src/common/Page.ts
@@ -2258,7 +2258,7 @@ export class CDPPage extends Page {
    *
    * - `height`: page's height in pixels
    *
-   * - `deviceScalarFactor`: Specify device scale factor (can be though of as
+   * - `deviceScaleFactor`: Specify device scale factor (can be though of as
    *   dpr). Defaults to `1`.
    *
    * - `isMobile`: Whether the meta viewport tag is taken into account. Defaults

diff --git a/website/versioned_docs/version-19.2.2/api/puppeteer.page.viewport.md b/website/versioned_docs/version-19.2.2/api/puppeteer.page.viewport.md
@@ -20,7 +20,7 @@ class Page {
 
 - `height`: page's height in pixels
 
-- `deviceScalarFactor`: Specify device scale factor (can be though of as dpr). Defaults to `1`.
+- `deviceScaleFactor`: Specify device scale factor (can be though of as dpr). Defaults to `1`.
 
 - `isMobile`: Whether the meta viewport tag is taken into account. Defaults to `false`.