Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in Viewport fields #9293

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Conversation

GuillaumeGomez
Copy link
Contributor

The deviceScalarFactor field of Viewport is actually named deviceScaleFactor.

@OrKoN OrKoN changed the title Fix typo in Viewport fields docs: fix typo in Viewport fields Nov 17, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@OrKoN
Copy link
Collaborator

OrKoN commented Nov 17, 2022

Thanks!

@OrKoN OrKoN merged commit 0a2d310 into puppeteer:main Nov 17, 2022
OrKoN pushed a commit that referenced this pull request Nov 23, 2022
The `deviceScalarFactor` field of `Viewport` is actually named
`deviceScaleFactor`.
OrKoN pushed a commit that referenced this pull request Nov 23, 2022
The `deviceScalarFactor` field of `Viewport` is actually named
`deviceScaleFactor`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants