Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page.waitForFunction does not support disable timeout #2200

Closed
vc1 opened this issue Mar 15, 2018 · 2 comments · Fixed by #2252
Closed

page.waitForFunction does not support disable timeout #2200

vc1 opened this issue Mar 15, 2018 · 2 comments · Fixed by #2252
Labels
feature good first issue

Comments

@vc1
Copy link

vc1 commented Mar 15, 2018

Steps to reproduce

Tell us about your environment:

  • Puppeteer version: 1.1.1

page.goto support disable timeout. The usage of timeout is not the same
Need: pass 0 to disable timeout wait forerve
@yanivefraim
Copy link
Contributor

yanivefraim commented Mar 16, 2018 •
edited

I'll be happy to take this one (:

@aslushnikov @vc1

@aslushnikov
Copy link
Contributor

@yanivefraim please go ahead!

@yanivefraim yanivefraim mentioned this issue Mar 23, 2018
Merged
aslushnikov pushed a commit that referenced this issue Mar 28, 2018
@yanivefraim @aslushnikov
feat(page): add an option to disable timeout for waitForFunction (#2252)
abb05e0 
This patch adds support for `timeout: 0` to disable timeout for the following functions:
- `page.waitForFunction`
- `page.waitForXPath`
- `page.waitForSelector`
and their `frame` counterparts.

Fixes #2200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(page): add an option to disable timeout for waitForFunction yanivefraim/puppeteer
3 participants
@aslushnikov @yanivefraim @vc1