feat(page): add an option to disable timeout for waitForFunction #2252
Conversation
test/frame.spec.js
Outdated
| @@ -145,6 +145,12 @@ module.exports.addTests = function({testRunner, expect}) { | |||
| await page.evaluate(element => element.remove(), div); | |||
| await waitForFunction; | |||
| }); | |||
| it('should disable timeout when its set to 0', async({page}) => { | |||
| let error = null; | |||
| const res = await page.waitForFunction(() => new Promise(res => setTimeout(() => res(42), 1000)), {timeout: 0}).catch(e => error = e); | |||
There was a problem hiding this comment.
nit: let's do it 100ms to have less impact on test time.
|
@yanivefraim we're figuring the typescript issues; seems to be related to today's ts release. |
@yanivefraim by the way, this patch just did this for waitForSelector and waitForXPath. Can you please update documentation to mention this? |
@aslushnikov - Good catch (I thought about it but forgot to update docs). I updated the docs accordingly. |
| @@ -1406,7 +1406,7 @@ Shortcut for [page.mainFrame().waitForSelector(selector[, options])](#framewaitf | |||
| - `options` <[Object]> Optional waiting parameters | |||
| - `visible` <[boolean]> wait for element to be present in DOM and to be visible, i.e. to not have `display: none` or `visibility: hidden` CSS properties. Defaults to `false`. | |||
| - `hidden` <[boolean]> wait for element to not be found in the DOM or to be hidden, i.e. have `display: none` or `visibility: hidden` CSS properties. Defaults to `false`. | |||
| - `timeout` <[number]> maximum time to wait for in milliseconds. Defaults to `30000` (30 seconds). | |||
| - `timeout` <[number]> maximum time to wait for in milliseconds. Defaults to `30000` (30 seconds). Pass `0` to disable timeout. | |||
There was a problem hiding this comment.
can you please change frame.waitForSelector and frame.waitForXPath as well?
There was a problem hiding this comment.
sure, sorry (missed those). done...
@yanivefraim I think we're good |
closes #2200
Maybe we should consider adding this feature to all available timeouts? (waitForSelector, waitForXPath etc.)