Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 6 support #316

Closed
maclover7 opened this issue Aug 17, 2017 · 11 comments
Closed

Node 6 support #316

maclover7 opened this issue Aug 17, 2017 · 11 comments
Assignees
Labels

Comments

@maclover7
Copy link

Per the package.json file, it looks like puppeteer only works on Node versions >=7.10.0. Would you be willing to maintain this package on the Node 6 release line, since it is the current LTS version?

@JoelEinbinder
Copy link
Collaborator

We don't have any plans to work with Node 6 at this point. Considering how much we rely on newer JavaScript features, supported Node 6 would be difficult for us to support. We don't want to take on the cost of a compile step or fracture our codebase.

@rwjblue
Copy link

rwjblue commented Aug 17, 2017

Seems pretty surprising to specifically not support the current node LTS version.

@pavelfeldman pavelfeldman reopened this Aug 17, 2017
@pavelfeldman
Copy link
Contributor

Node 8 goes LTS in October 2017. It is likely that Puppeteer will go stable 1.0 right after that.

@waynerobinson
Copy link

Yeah, Node 6.10 support would help potentially being able to get this to work in AWS Lambda.

@mgcrea
Copy link

mgcrea commented Aug 19, 2017

Encountering this as well, since our production services all run on LTS, risk is too high to start developing/testing on a different non-LTS version not matching production env.

Looks like it could easily be fixed with some babel plugins without changing anything, like transform-async-to-generator or a preset.

When 8.0 reaches LTS you could then consider deprecating legacy support, and dropping it a couple of months later?

@rfink
Copy link

rfink commented Aug 26, 2017

Has anybody been able to actually get this working on lambda? The download size of puppeteer alone is larger than the max size allowed by lambda.

@brafdlog
Copy link

I was able to upload it to lambda after deleting a few of the locale files inside chrome but it would not run. Some issue with permissions. Haven't figured it out yet.

@alixaxel
Copy link
Contributor

alixaxel commented Oct 7, 2017

@rfink @brafdlog I managed to deploy a compiled version of Chromeless compressed with Brotli along with a trimmed down version of iltorb for decompressing it in under 34MiB ZIP package.

It also decompresses faster.

@bluepeter
Copy link

bluepeter commented Oct 11, 2017

@alixaxel mind forking one of those repos, or making a new one, with your Chrome builds? ... particularly the one that clocks in at 34mb, as well as the "trimmed down" versions of related modules. or post the gist steps?

@sushant-j
Copy link

@mgcrea - Looking to run it on 6.10, but getting ReferenceError: regeneratorRuntime is not defined error. Something I am doing wrong?

@JoelEinbinder
Copy link
Collaborator

@sushant-j You can't use async functions in page.evaluate or equivalent methods if you are using a transpiler like babel or regenerator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests