Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add an E2E test for device request prompt #11159

Merged
merged 5 commits into from
Oct 16, 2023
Merged

test: add an E2E test for device request prompt #11159

merged 5 commits into from
Oct 16, 2023

Conversation

thiagowfx
Copy link
Contributor

@thiagowfx thiagowfx commented Oct 13, 2023 •
edited

Closes #11072

@thiagowfx thiagowfx changed the base branch from main to thiagowfx/device-prompt October 13, 2023 16:02
@thiagowfx
Copy link
Contributor Author

thiagowfx commented Oct 13, 2023 •
edited

The diffbase will become less noisy once the parent PRs are merged.

@thiagowfx thiagowfx mentioned this pull request Oct 13, 2023
Merged
@thiagowfx thiagowfx force-pushed the thiagowfx/device-prompt-e2e branch 2 times, most recently from 958db9a to 9b6c98e Compare October 13, 2023 16:20
Base automatically changed from thiagowfx/device-prompt to main October 15, 2023 14:32
@thiagowfx thiagowfx force-pushed the thiagowfx/device-prompt-e2e branch 2 times, most recently from 7b84b1f to 29511db Compare October 16, 2023 09:44
@thiagowfx thiagowfx enabled auto-merge (squash) October 16, 2023 10:15
@thiagowfx thiagowfx enabled auto-merge (squash) October 16, 2023 12:27
@thiagowfx thiagowfx mentioned this pull request Oct 16, 2023
Closed
2 tasks
auto-merge was automatically disabled October 16, 2023 12:37

Base branch was modified

@thiagowfx thiagowfx enabled auto-merge (squash) October 16, 2023 12:51
@thiagowfx thiagowfx merged commit c6333cb into main Oct 16, 2023
53 checks passed
@thiagowfx thiagowfx deleted the thiagowfx/device-prompt-e2e branch October 16, 2023 13:50
@outofambit outofambit mentioned this pull request Oct 17, 2023
Closed
@thiagowfx thiagowfx mentioned this pull request Oct 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

@OrKoN OrKoN Awaiting requested review from OrKoN

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Puppeteer crashes on waitForDevicePrompt()
2 participants
@thiagowfx @Lightning00Blade